(About me section, skip if uninterested)
I am a casual League player, about platinum 2 skill level when Emerald wasn't a thing and haven't tried to grind ranked seriously after that.
I play ADC's now for most part in 2 weeks phases during the year when my friends want to play like some of you do probably with minecraft.
I like this champion it feels fun, but it feels functioning only because my friend is bronze1-silver3 and I can get fed so much that weaknesses on this champ don't matter.
But when I try this champion in Gold-Emerald range where people are a bit more careful and skilled the middle ground between ADC and Assassin feels terrible. I'll spare the bad parts since probably all of you know them except one, that even when things go well enemies get away since Samira doesn't have the stickiness of some ADC's like Ashe.
The best strength honestly is being able to scare the enemy ADC even when behind, sometimes they try to do an ego flank and you chunk them good enough that they run away, or helping your midlaner against an enemy assassin.
(Post question about passive being useless and needing a change)
I just feel like the Style mini game exists mostly for the Ultimate and becomes later a bit better Miss Fortune's W passive, iirc since I didn't open the game in 4 months but judging by how the first post I saw was complaining about the lack of buffs, I am guessing we are building the same items so we don't take many movement speed items.
The melee attack is nice when playing against yasuo but how many melee's do we get in? If someone bothered with the math I would bet on it being much less than other damage boosting passives.
The best part is the special AA on CC'd targets because it synergizes with her whole kit, but again after laning phase if you math it out I would bet on it being very underperforming compared to other ADC's
(My suggestion)
I would suggest putting the Style part of passive on Ultimate and making a new passive. or making a new passive and putting it on Ultimate.
Something like giving fragile on enemies hit a certain amount of times. (Originally I put here a suggestion that she does bonus damage against low hp% targets then saw that she already does that but I never noticed that in gameplay) Hell maybe just giving 1% of lifesteal for each Style point would fix everything.
Right now Samira feels like a champion with half the kit of other champions which puts her in a place where she is either broken because numbers are so big that doesn't matter, or the numbers are balanced but they can't be used so everyone beats her.
Honestly to me she really feels like Pre Rework Aatrox, (before they buffed him into broken tier)
1 part of the kit was only useful in laning (The weird projectile), after you went in you weren't getting out, you relied on your Ultimate and had some niche strengths, but overall were beaten in more important roles, and oh yeah a passive that worked against you in most situations instead of for you.
Curious for thoughts from other player that have more hours on the champ.